Files
kino-app/backend/tests/test_phase4_queue.py
T
2026-04-29 16:33:26 +00:00

330 lines
13 KiB
Python

"""Phase 4: Transcode Queue tests.
Covers:
- Queue stats & list (admin only)
- Settings persistence for auto_transcode + queue_paused
- Manual + auto enqueue
- Worker FIFO processing
- Cancel/Retry/Clear/Pause flows
- 409 conflict guard
- Pause idle behavior
- Crash-recovery code path (running -> failed) by direct DB insert + restart
"""
import os
import time
import uuid
import pytest
import requests
BASE_URL = os.environ["REACT_APP_BACKEND_URL"].rstrip("/")
ADMIN_EMAIL = "admin@kino.local"
ADMIN_PASSWORD = "kino-admin-2026"
QTEST_VIDEO = "/tmp/qtest.mp4"
# ---------- Fixtures ----------
@pytest.fixture(scope="session")
def api():
s = requests.Session()
return s
@pytest.fixture(scope="session")
def admin_token(api):
r = api.post(f"{BASE_URL}/api/auth/login",
json={"email": ADMIN_EMAIL, "password": ADMIN_PASSWORD},
headers={"Content-Type": "application/json"})
assert r.status_code == 200, r.text
return r.json()["access_token"]
@pytest.fixture(scope="session")
def member_token(api):
email = f"TEST_q_{uuid.uuid4().hex[:8]}@kino.local"
r = api.post(f"{BASE_URL}/api/auth/register",
json={"email": email, "password": "pass1234", "name": "QTest"},
headers={"Content-Type": "application/json"})
assert r.status_code == 200, r.text
return r.json()["access_token"]
@pytest.fixture
def admin_headers(admin_token):
return {"Authorization": f"Bearer {admin_token}"}
@pytest.fixture
def member_headers(member_token):
return {"Authorization": f"Bearer {member_token}"}
def _set_settings(api, admin_headers, **kwargs):
"""Helper: PUT /api/settings preserving existing keys, override with kwargs."""
cur = api.get(f"{BASE_URL}/api/settings", headers=admin_headers).json()
body = {
"tmdb_api_key": cur.get("tmdb_api_key", ""),
"radarr_url": cur.get("radarr_url", ""),
"radarr_api_key": cur.get("radarr_api_key", ""),
"auto_transcode": cur.get("auto_transcode", "off"),
"queue_paused": cur.get("queue_paused", False),
}
body.update(kwargs)
r = api.put(f"{BASE_URL}/api/settings", json=body,
headers={**admin_headers, "Content-Type": "application/json"})
assert r.status_code == 200, r.text
return r.json()
def _upload_movie(api, admin_headers, title):
with open(QTEST_VIDEO, "rb") as f:
r = api.post(
f"{BASE_URL}/api/upload/video",
data={"title": title, "year": 2024, "rating": "NR", "genres": "Test"},
files={"file": (f"{title}.mp4", f, "video/mp4")},
headers=admin_headers,
)
assert r.status_code == 200, r.text
return r.json()
# Cleanup at end of module
@pytest.fixture(scope="module", autouse=True)
def _cleanup(request):
yield
# best-effort: reset settings & clear queue via admin
try:
s = requests.Session()
tok = s.post(f"{BASE_URL}/api/auth/login",
json={"email": ADMIN_EMAIL, "password": ADMIN_PASSWORD},
headers={"Content-Type": "application/json"}).json()["access_token"]
h = {"Authorization": f"Bearer {tok}", "Content-Type": "application/json"}
s.put(f"{BASE_URL}/api/settings", json={
"tmdb_api_key": "", "radarr_url": "", "radarr_api_key": "",
"auto_transcode": "off", "queue_paused": False,
}, headers=h)
s.post(f"{BASE_URL}/api/transcode/queue/clear", headers=h)
# delete TEST_ movies created
movies = s.get(f"{BASE_URL}/api/movies?limit=500", headers=h).json()
for m in movies:
if m.get("title", "").startswith("TEST_Q_"):
s.delete(f"{BASE_URL}/api/movies/{m['id']}", headers=h)
except Exception:
pass
# ---------- Tests ----------
class TestQueueAuth:
def test_queue_list_admin_only(self, api, member_headers):
r = api.get(f"{BASE_URL}/api/transcode/queue", headers=member_headers)
assert r.status_code == 403
def test_queue_stats_admin_only(self, api, member_headers):
r = api.get(f"{BASE_URL}/api/transcode/queue/stats", headers=member_headers)
assert r.status_code == 403
class TestQueueStatsAndSettings:
def test_stats_shape(self, api, admin_headers):
r = api.get(f"{BASE_URL}/api/transcode/queue/stats", headers=admin_headers)
assert r.status_code == 200
d = r.json()
for k in ("pending", "running", "done", "failed", "cancelled", "paused", "auto_transcode"):
assert k in d, f"missing {k}"
assert isinstance(d["paused"], bool)
def test_settings_persists_auto_and_paused(self, api, admin_headers):
d = _set_settings(api, admin_headers, auto_transcode="quick", queue_paused=False)
assert d["auto_transcode"] == "quick"
assert d["queue_paused"] is False
# GET to verify persistence
g = api.get(f"{BASE_URL}/api/settings", headers=admin_headers).json()
assert g["auto_transcode"] == "quick"
# reset
_set_settings(api, admin_headers, auto_transcode="off")
class TestManualEnqueueAndWorker:
def test_upload_with_auto_off_no_job(self, api, admin_headers):
_set_settings(api, admin_headers, auto_transcode="off", queue_paused=False)
api.post(f"{BASE_URL}/api/transcode/queue/clear", headers=admin_headers)
movie = _upload_movie(api, admin_headers, "TEST_Q_off")
time.sleep(1)
# No job for this movie
rows = api.get(f"{BASE_URL}/api/transcode/queue", headers=admin_headers).json()
assert not any(j["movie_id"] == movie["id"] for j in rows)
# cleanup
api.delete(f"{BASE_URL}/api/movies/{movie['id']}", headers=admin_headers)
def test_manual_transcode_and_worker_runs(self, api, admin_headers):
_set_settings(api, admin_headers, auto_transcode="off", queue_paused=False)
movie = _upload_movie(api, admin_headers, "TEST_Q_manual")
mid = movie["id"]
r = api.post(f"{BASE_URL}/api/movies/{mid}/transcode",
json={"quality": "quick"},
headers={**admin_headers, "Content-Type": "application/json"})
assert r.status_code == 200, r.text
body = r.json()
assert body["status"] == "pending"
assert "job_id" in body
# movie hls_status pending
m = api.get(f"{BASE_URL}/api/movies/{mid}").json()
assert m["hls_status"] in ("pending", "running", "done")
# 409 conflict when re-triggering
r2 = api.post(f"{BASE_URL}/api/movies/{mid}/transcode",
json={"quality": "quick"},
headers={**admin_headers, "Content-Type": "application/json"})
assert r2.status_code == 409
# Wait for completion (worker polls every 8s; quick transcode of 3s clip <30s)
deadline = time.time() + 60
final = None
while time.time() < deadline:
m = api.get(f"{BASE_URL}/api/movies/{mid}").json()
if m.get("hls_status") in ("done", "failed"):
final = m["hls_status"]
break
time.sleep(2)
assert final == "done", f"hls did not complete; status={final}"
rows = api.get(f"{BASE_URL}/api/transcode/queue?status=done",
headers=admin_headers).json()
assert any(j["movie_id"] == mid and j["status"] == "done" for j in rows)
# cleanup
api.delete(f"{BASE_URL}/api/movies/{mid}", headers=admin_headers)
def test_retry_done_job_returns_400(self, api, admin_headers):
rows = api.get(f"{BASE_URL}/api/transcode/queue?status=done",
headers=admin_headers).json()
if not rows:
pytest.skip("No done jobs available for retry-400 test")
r = api.post(f"{BASE_URL}/api/transcode/queue/{rows[0]['id']}/retry",
headers=admin_headers)
assert r.status_code == 400
class TestAutoEnqueue:
def test_auto_quick_enqueues_on_upload(self, api, admin_headers):
_set_settings(api, admin_headers, auto_transcode="quick", queue_paused=True)
# paused so the job stays pending
movie = _upload_movie(api, admin_headers, "TEST_Q_auto")
mid = movie["id"]
time.sleep(1)
rows = api.get(f"{BASE_URL}/api/transcode/queue", headers=admin_headers).json()
match = [j for j in rows if j["movie_id"] == mid]
assert match, "Auto-enqueue did not create a job"
job = match[0]
assert job["quality"] == "quick"
assert job["triggered_by"] == "auto"
# While paused, should remain pending (worker polls every 15s when paused)
time.sleep(3)
rows2 = api.get(f"{BASE_URL}/api/transcode/queue", headers=admin_headers).json()
j2 = next(j for j in rows2 if j["movie_id"] == mid)
assert j2["status"] == "pending", f"Job should stay pending while paused, got {j2['status']}"
# Cancel the pending job
c = api.delete(f"{BASE_URL}/api/transcode/queue/{job['id']}", headers=admin_headers)
assert c.status_code == 200
# status -> cancelled, movie hls_status reset
rows3 = api.get(f"{BASE_URL}/api/transcode/queue", headers=admin_headers).json()
j3 = next(j for j in rows3 if j["id"] == job["id"])
assert j3["status"] == "cancelled"
m = api.get(f"{BASE_URL}/api/movies/{mid}").json()
assert m.get("hls_status") in (None, "")
# Retry cancelled job creates new pending job
rt = api.post(f"{BASE_URL}/api/transcode/queue/{job['id']}/retry",
headers=admin_headers)
assert rt.status_code == 200, rt.text
new_id = rt.json()["job_id"]
assert new_id != job["id"]
# Cancel again to clean up
api.delete(f"{BASE_URL}/api/transcode/queue/{new_id}", headers=admin_headers)
# Reset settings
_set_settings(api, admin_headers, auto_transcode="off", queue_paused=False)
api.delete(f"{BASE_URL}/api/movies/{mid}", headers=admin_headers)
class TestCancelRunningRejected:
def test_cancel_running_returns_400(self, api, admin_headers):
# Inject a fake "running" row directly via... we don't have DB access here.
# Instead, attempt an actual run: upload, manual transcode, poll for running
_set_settings(api, admin_headers, auto_transcode="off", queue_paused=False)
movie = _upload_movie(api, admin_headers, "TEST_Q_running")
mid = movie["id"]
r = api.post(f"{BASE_URL}/api/movies/{mid}/transcode",
json={"quality": "quick"},
headers={**admin_headers, "Content-Type": "application/json"})
assert r.status_code == 200
job_id = r.json()["job_id"]
# Poll for running status (worker idles up to 8s)
deadline = time.time() + 30
saw_running = False
while time.time() < deadline:
rows = api.get(f"{BASE_URL}/api/transcode/queue", headers=admin_headers).json()
j = next((x for x in rows if x["id"] == job_id), None)
if j and j["status"] == "running":
saw_running = True
# Try to cancel -> 400
c = api.delete(f"{BASE_URL}/api/transcode/queue/{job_id}", headers=admin_headers)
assert c.status_code == 400
break
if j and j["status"] in ("done", "failed"):
break
time.sleep(0.5)
# Wait for completion before cleanup
deadline = time.time() + 60
while time.time() < deadline:
m = api.get(f"{BASE_URL}/api/movies/{mid}").json()
if m.get("hls_status") in ("done", "failed"):
break
time.sleep(2)
api.delete(f"{BASE_URL}/api/movies/{mid}", headers=admin_headers)
if not saw_running:
pytest.skip("Could not catch a 'running' job in time window — non-deterministic")
class TestClearFinished:
def test_clear_removes_finished(self, api, admin_headers):
before = api.get(f"{BASE_URL}/api/transcode/queue/stats",
headers=admin_headers).json()
r = api.post(f"{BASE_URL}/api/transcode/queue/clear", headers=admin_headers)
assert r.status_code == 200
d = r.json()
assert "deleted" in d
# after clear, done/failed/cancelled = 0
after = api.get(f"{BASE_URL}/api/transcode/queue/stats",
headers=admin_headers).json()
assert after["done"] == 0
assert after["failed"] == 0
assert after["cancelled"] == 0
class TestPauseToggle:
def test_pause_endpoint_sets_flag(self, api, admin_headers):
r = api.post(f"{BASE_URL}/api/transcode/queue/pause",
json={"paused": True},
headers={**admin_headers, "Content-Type": "application/json"})
assert r.status_code == 200
assert r.json()["paused"] is True
s = api.get(f"{BASE_URL}/api/transcode/queue/stats",
headers=admin_headers).json()
assert s["paused"] is True
# reset
api.post(f"{BASE_URL}/api/transcode/queue/pause",
json={"paused": False},
headers={**admin_headers, "Content-Type": "application/json"})
class TestNicePrefix:
def test_transcode_module_uses_nice(self):
"""Code-level: ffmpeg commands prefixed with `nice -n 19`."""
src = open("/app/backend/transcode.py").read()
assert "\"nice\", \"-n\", \"19\"" in src
# appears in both quick and abr
assert src.count("\"nice\", \"-n\", \"19\"") >= 2